This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] shared_info size and padding fixes

To: John Levon <levon@xxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] shared_info size and padding fixes
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 10 Aug 2006 14:29:25 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 10 Aug 2006 06:29:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060810121348.GA24928@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aca8gP8yPcNSTih0EduG6AAKle7CWA==
Thread-topic: [Xen-devel] [PATCH] shared_info size and padding fixes
User-agent: Microsoft-Entourage/

On 10/8/06 1:13 pm, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> No, see the previous discussion with Keir - changing the size of the
> shared info structure is apparently not part of the ABI (hence the
> reason for the patch and the explanation above!)
> Personally this seems unusual at best to me, but that's the way it is,
> and furthermore has already happened with "nmi_reason".

Your patch looked fine, by the way, except that adding padding to every
arch-specific portion of shared info seems unnecessary.

 -- Keir

Xen-devel mailing list