Re: [Xen-devel] [PATCH] shared_info size and padding fixes

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Mercredi 09 Août 2006 23:05, John Levon a écrit :
> # HG changeset patch
> # User john.levon@xxxxxxx
> # Date 1155157246 -3600
> # Node ID e24df0e22cdfe6daaa0d4d40c88e13c0427a1515
> # Parent  b60ea69932b1a4d10c3aae945a1ce1aa160c689b
> sizeof(shared_info_t) can change even in compatible hypervisor versions.
> Add a clear warning about this, and fix the few places relying on it.
> In addition, add some padding to arch_shared_info, to allow future
> additions to the structure without breaking known offsets of members
> following it in the shared info.
Hi,

Comment for ia64:

[...]
> diff -r b60ea69932b1 -r e24df0e22cdf xen/arch/ia64/asm-offsets.c
> --- a/xen/arch/ia64/asm-offsets.c     Wed Aug 09 18:04:20 2006 +0100
> +++ b/xen/arch/ia64/asm-offsets.c     Wed Aug 09 22:00:46 2006 +0100
> @@ -31,7 +31,6 @@ void foo(void)
>       DEFINE(IA64_SWITCH_STACK_SIZE, sizeof (struct switch_stack));
>       DEFINE(IA64_CPU_SIZE, sizeof (struct cpuinfo_ia64));
>       DEFINE(UNW_FRAME_INFO_SIZE, sizeof (struct unw_frame_info));
> -     DEFINE(SHARED_INFO_SIZE, sizeof (struct shared_info));
>
>       BLANK();
>       DEFINE(IA64_MCA_CPU_INIT_STACK_OFFSET, offsetof (struct ia64_mca_cpu,
> init_stack)); diff -r b60ea69932b1 -r e24df0e22cdf
[...]

Please, do not remove this define.  It is used to check the struct is not 
bigger than a page!

Tristan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel