Re: [Xen-devel] [PATCH] shared_info size and padding fixes

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Jeudi 10 Août 2006 10:31, Jan Beulich a écrit :
> >>    DEFINE(IA64_SWITCH_STACK_SIZE, sizeof (struct switch_stack));
> >>    DEFINE(IA64_CPU_SIZE, sizeof (struct cpuinfo_ia64));
> >>    DEFINE(UNW_FRAME_INFO_SIZE, sizeof (struct unw_frame_info));
> >> -  DEFINE(SHARED_INFO_SIZE, sizeof (struct shared_info));
> >>
> >>    BLANK();
> >>    DEFINE(IA64_MCA_CPU_INIT_STACK_OFFSET, offsetof (struct
>
> ia64_mca_cpu,
>
> >Please, do not remove this define.  It is used to check the struct is
>
> not
>
> >bigger than a page!
>
> Checking this should be done with BUILD_BUG_ON() in a .c file, and
> hence
> not require an entry in asm-offsets.c.
Thank you for the tip.
I will write a patch for this.

Tristan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel