This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] shared_info size and padding fixes

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>, "John Levon" <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] shared_info size and padding fixes
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Thu, 10 Aug 2006 10:42:43 +0200
Delivery-date: Thu, 10 Aug 2006 01:38:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44DB0B0D.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060809210528.GA31314@xxxxxxxxxxxxxxxxxxxx> <200608101003.37572.Tristan.Gingold@xxxxxxxx> <44DB0B0D.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Jeudi 10 Août 2006 10:31, Jan Beulich a écrit :
> >>    DEFINE(IA64_SWITCH_STACK_SIZE, sizeof (struct switch_stack));
> >>    DEFINE(IA64_CPU_SIZE, sizeof (struct cpuinfo_ia64));
> >>    DEFINE(UNW_FRAME_INFO_SIZE, sizeof (struct unw_frame_info));
> >> -  DEFINE(SHARED_INFO_SIZE, sizeof (struct shared_info));
> >>
> >>    BLANK();
> >>    DEFINE(IA64_MCA_CPU_INIT_STACK_OFFSET, offsetof (struct
> ia64_mca_cpu,
> >Please, do not remove this define.  It is used to check the struct is
> not
> >bigger than a page!
> Checking this should be done with BUILD_BUG_ON() in a .c file, and
> hence
> not require an entry in asm-offsets.c.
Thank you for the tip.
I will write a patch for this.


Xen-devel mailing list