|
xen-devel
[Xen-devel] Re: [RFC PATCH 05/33] Makefile support to build Xen subarch
|
To: |
Andrew Morton <akpm@xxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [RFC PATCH 05/33] Makefile support to build Xen subarch |
|
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Date: |
Tue, 18 Jul 2006 13:41:48 -0700 |
|
Cc: |
zach@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.pratt@xxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, ak@xxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, chrisw@xxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, Christian.Limpach@xxxxxxxxxxxx, Arjan van de Ven <arjan@xxxxxxxxxxxxx> |
|
Delivery-date: |
Thu, 20 Jul 2006 05:27:08 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20060718044007.74324d93.akpm@xxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20060718091807.467468000@xxxxxxxxxxxx> <20060718091949.842251000@xxxxxxxxxxxx> <1153216813.3038.22.camel@xxxxxxxxxxxxxxxxxxxxx> <20060718044007.74324d93.akpm@xxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 1.5.0.4 (X11/20060613) |
Andrew Morton wrote:
@@ -99,6 +103,7 @@ drivers-$(CONFIG_PM) += arch/i386/powe
CFLAGS += $(mflags-y)
AFLAGS += $(mflags-y)
+CPPFLAGS += $(mflags-y)
This change affects _all_ subarchitectures (by potentially altering their
CPPFLAGS) and it's rather a mystery why one subarch needs the -Ifoo in its
CPPFLAGS whereas all the others do not.
The reason is that arch-i386/kernel/vmlinux.lds.S is run through CPP,
and it includes asm/thread_info.h and asm/page.h, which end up including
"mach_page.h" (which this patch series introduces). There is a version
in both mach-default/mach_page.h and mach-xen/mach_page.h, so the -I is
necessary for non-Xen sub-arches as well.
I guess the conservative approach would be to only add this -I for the
vmlinux.lds target, assuming there are no later compile problems. On
the flip-side, would you want C and Asm code getting a different set of
includes from "manually" preprocessed-files? I would think you'd want
either defines/includes at all, or to have them identical.
The CPPFLAGS assignment also appears to make the previous two lines
redundant, since a_flags and c_flags (which is what actually gets used
for compilation) end up having CPPFLAGS incorporated into them.
J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home