|
xen-devel
[Xen-devel] Re: [RFC PATCH 09/33] Add start-of-day setup hooks to subarc
|
To: |
Chris Wright <chrisw@xxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [RFC PATCH 09/33] Add start-of-day setup hooks to subarch |
|
From: |
Arjan van de Ven <arjan@xxxxxxxxxxxxx> |
|
Date: |
Tue, 18 Jul 2006 12:03:53 +0200 |
|
Cc: |
Andrew Morton <akpm@xxxxxxxx>, Zachary Amsden <zach@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Andi Kleen <ak@xxxxxxx>, virtualization@xxxxxxxxxxxxxx, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx> |
|
Delivery-date: |
Thu, 20 Jul 2006 05:09:01 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20060718091950.750213000@xxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Organization: |
Intel International BV |
|
References: |
<20060718091807.467468000@xxxxxxxxxxxx> <20060718091950.750213000@xxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote:
> plain text document attachment (i386-setup)
> Implement the start-of-day subarchitecture setup hooks for booting on
> Xen. Add subarch macros for determining loader type and initrd
> location.
> diff -r a5848bce3730 arch/i386/kernel/setup.c
> --- a/arch/i386/kernel/setup.c Thu Jun 22 16:02:54 2006 -0400
> +++ b/arch/i386/kernel/setup.c Thu Jun 22 20:20:31 2006 -0400
> @@ -458,6 +458,7 @@ static void __init print_memory_map(char
> }
> }
>
> +#ifndef HAVE_ARCH_E820_SANITIZE
> /*
> * Sanitize the BIOS e820 map.
> *
> @@ -677,6 +678,7 @@ int __init copy_e820_map(struct e820entr
> } while (biosmap++,--nr_map);
> return 0;
> }
> +#endif
>
Hi,
what is this for? Isn't this 1) undocumented and 2) unclear and 3)
ugly ? (I'm pretty sure the HAVE_ARCH_* stuff is highly deprecated for
new things nowadays)
Greetings,
Arjan van de Ven
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home