Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 15 May 2006, at 21:46, Andi Kleen wrote:

> > What I'm fighting now is getting linux/arch/x86_64/mm/numa.c to build.
> > Some of the structures to track numa info (struct pglist_data) are
> > rather linux specific and include lots of structures related to Linux 
> > mm
> > zones, check out linux/include/linux/mmzone.h.  I attempted to avoid
> > bring in that in, but the pfn_to_nid/phys_to_nid macros are based on
> > memnodemap array.
> I guess you can just replace setup_node_bootmem / setup_node_zones /
> numa_free_all_bootmem with Xen specific functions. They should be the 
> only
> functions dealing with pglists and they're relatively straight forward.
Yes, my gut feeling looking at x86_64's numa.c is that it's going to 
need some heavier surgery than srat.c. I wouldn't worry so much about 
keeping that one close to the Linux original: if we end up pulling down 
more Linux memory bookkeeping code later then we can always go back and 
sync the file more closely. Keep it as clean as possible though, 
obviously (e.g., replacing whole functions is nicer than functions that 
are a hacky halfway house between Linux and Xen, etc).
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel