WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen
From: Ryan Harper <ryanh@xxxxxxxxxx>
Date: Wed, 24 May 2006 14:02:23 -0500
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ryan Grimm <grimm@xxxxxxxxxx>
Delivery-date: Wed, 24 May 2006 12:02:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200605221301.30662.ak@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060501215648.GU16776@xxxxxxxxxx> <403a4dbd4c7329e3de93e78054d5ffaf@xxxxxxxxxxxx> <20060519210857.GR16876@xxxxxxxxxx> <200605221301.30662.ak@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
* Andi Kleen <ak@xxxxxxx> [2006-05-22 06:02]:
> 
> > The patch is function on 32-bit and 64-bit boxes and parse the SRAT
> > table and fills out the node_data array.  I installed a simple
> > keyhandler 'u' to dump the info to check that it was function after
> > booting up.
> 
> It mostly looks reasonable. As Keir noted you seem to have a lot of 
> unnecessary
> changes (printk->DPRINTK, white space etc.)

Cleaned up.

> 
> I would also suggest you keep the numa emulation. It's useful for debugging
> so that developers without numa machines can reproduce numa issues.

Added numa emulation back in.  I've set it up such that if we fail to
find a numa-node we fallback on to emulation of one node.  This allows
the allocator code to not be filled with CONFIG_NUMA ifdefs as Keir
wanted. 

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@xxxxxxxxxx

Attachment: acpi_numa.tgz
Description: GNU Unix tar archive

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel