[Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 15 May 2006, at 17:27, Andi Kleen wrote:

> >   1. You re-indented. Normally a good thing but not for copies of
> > Linux source files. Please edit them and maintain them in Linux style
> > (inc. hard tabs) as it makes it easier to sync with Linux updates.
> What Linux updates? The i386 NUMA support is basically dead and
> bitrots slowly (except perhaps on NUMAQ) Every half a year someone
> uses it and finds it doesn't work, maybe even fixes it and then it
> breaks shortly after again. That's because it isn't used and tested in
> any significant way. No distribution I'm aware of uses it either.
>
> If you want maintained NUMA it would be much better to base on the 
> x86-64
> NUMA code.
Sounds like an excellent plan to me: the x86/64 code looks cleaner too. 
Let's go with the x86/64 code then, unless there are any objections 
from the IBM folks?
Of course that will mean that stuff that has 'leaked out' from i386's 
srat.c (node_memory_chunk!) will definitely need to be got rid of, but 
that needed cleaning up anyway.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel