 Home |
Products |
Support |
Community |
News |
xen-devel
RE: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races
| To: | "Markus Armbruster" <armbru@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | RE: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races |
| From: | "Santos, Jose Renato G" <joserenato.santos@xxxxxx> |
| Date: | Mon, 15 May 2006 14:51:44 -0700 |
| Delivery-date: | Mon, 15 May 2006 14:52:09 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <87psifyu8s.fsf@xxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcZ4VAftb5YJE269QHyM6dOspPHCJQAFEC0Q |
| Thread-topic: | [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races |
>> > Sorry, didn't mention this earlier. Please use new mutex >> code here, >> > smth like: >> > >> > s/DECLARE_MUTEX(adom_sec)/DEFINE_MUTEX(adomain_mutex)/ >> > s/down(&adom_sem)/mutex_lock(&adomain_mutex)/ >> > s/up(&adom_sem)/mutex_unlock(&admoain_mutex)/ >> > >> > thanks, >> > -chris >> >> What about buffer_sem in drivers/oprofile/event_buffer.c and >> start_sem in drivers/oprofile/oprof.c? Want me to submit a >> patch to convert all three? >> I think we should minimize changes to generic oprofile code (in drivers/oprofile) to minimize divergence from main stream linux. For this reason I don't think we should touch buffer_sem and start_sem. Renato _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| Previous by Date: | [Xen-devel] Daily Xen-HVM Build Testing: cs9988, Rick Gonzalez |
|---|---|
| Next by Date: | [Xen-devel] Re: [RFC PATCH 23/35] Increase x86 interrupt vector range, Chris Wright |
| Previous by Thread: | Re: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races, Markus Armbruster |
| Next by Thread: | Re: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races, Chris Wright |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
