|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
Re: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races
 
* Markus Armbruster (armbru@xxxxxxxxxx) wrote:
> --- linux-2.6.16.13-xen.patched-1/drivers/oprofile/oprofile_files.c   
> 2006-05-15 10:28:11.000000000 +0200
> +++ linux-2.6.16.13-xen.patched-2/drivers/oprofile/oprofile_files.c   
> 2006-05-15 10:31:11.000000000 +0200
> @@ -128,6 +128,7 @@ static struct file_operations dump_fops 
>  
>  unsigned int adomains = 0;
>  long active_domains[MAX_OPROF_DOMAINS];
> +static DECLARE_MUTEX(adom_sem);
Sorry, didn't mention this earlier.  Please use new mutex code here,
smth like:
s/DECLARE_MUTEX(adom_sec)/DEFINE_MUTEX(adomain_mutex)/
s/down(&adom_sem)/mutex_lock(&adomain_mutex)/
s/up(&adom_sem)/mutex_unlock(&admoain_mutex)/
thanks,
-chris
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 
 |   
 
 | 
    | 
  
  
    |   | 
    |