RE: [Xen-devel] [PATCH]vbd/vnif paravirtulization driver hypervisorsupport]

["Ling, Xiaofeng" <xiaofeng.ling@xxxxxxxxx>]

Ian Pratt <mailto:m+Ian.Pratt@xxxxxxxxxxxx> wrote:
>> Is there any comment for this patch?
>> Is it acceptable or not?
> 
> I think it needs a more work. Using grant tables should help unify
The grant table support is already in for vbd. and without grant table
configuration can also work.

> things. I'm convinced that you're missing out on some unifying
> paradigm that will cause many of the "if(VMX_DOMAIN(current))"
> clauses to evaporate.   
Most of the VMX_DOMAIN is used for copy_to/from_user, __get_user/__put_user
things.
Because VMX domain has separate address space. these function can not be used 
directly.
I've add a condition in copy_to/from_user, but some place, it uses separated 
array_access_ok  and __copy_to/from_user. 
For  __get_user/__put_user, in some place, that can still be used, like linear 
page table, some place,
that must be replaced with copy_to/from_guest.
So do you have better idea to deal with these things?
Or we use shadow_mode_external() to separate the path?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel