RE: [Xen-ia64-devel] [Patch] iosapic virtualization again

["Dong, Eddie" <eddie.dong@xxxxxxxxx>]

Same with previous, my comments is that we need to reuse xen/arch/x86/irq.c 
that support sharing IRQ with multiple guest . Actually that file comes from 
linux/kernel/irq.c combining with some arch/i386/kernel/irq.c.  So basically 
those common code should be reused while architecture specific part of them 
need to be renewed for IA64.
thx,eddie


Tian, Kevin wrote:
> Several coding style comments:
> 
> 1.
> +     if (vector == IA64_TIMER_VECTOR || vector == IA64_IPI_VECTOR)
> +             return 0;
> 
> For this point, I second Eddie to have irq descriptor add a flag to
> indicate whether belonging to xen or guest, instead of hardcode here.
> You can grep IRQ_GUEST in xen/arch/x86. Though guest SMP and driver
> domain is not ready yet, interface should be designed clean and well
> to allow better cooperation between guest and xen.    
> 
> 2. Not sure why you pull in iosapic.h into your patch. Seems no
> modification there which just need copy from linux source at compile
> time. If you really want to include this file, you can avoid adding
> xen_iosapic_write in c file and instead move its content to
> iosapic_write defined in iosapic.h    
> 
> 3. Why ifdef XEN but nothing changed:
> +#ifdef XEN
> +     vector = assign_irq_vector(AUTO_ASSIGN);
> +#else
> +     /* If vector is running out, we try to find a sharable vector */
> +#endif
> +     vector = assign_irq_vector(AUTO_ASSIGN);
> 
> 4. It's ugly to see:
> +#define VCPU_XEN ((struct vcpu *)1)
> Also no place to init vcpu with this value, however later it's
> checked when reflecting interrupt 
> 
> Thanks,
> Kevin
>> -----Original Message-----
>> From: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
>> [mailto:xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of
>> Tristan Gingold Sent: 2006年2月22日 17:57 To:
>> xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; Magenheimer, Dan (HP Labs Fort
>> Collins) Subject: [Xen-ia64-devel] [Patch] iosapic virtualization
>> again  
>> 
>> Hi,
>> 
>> here (again !) is my patch to virtualize iosapic.  I have just
>> updated it. 
>> 
>> Tristan.
> 
> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel