This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 00 of 45] gcc 4.6 compile fixes for xen-unstable

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 00 of 45] gcc 4.6 compile fixes for xen-unstable
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 20 May 2011 18:23:35 +0100
Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Fri, 20 May 2011 10:24:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C9FBE74F.2D7EB%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <1305880090.20576.1.camel@xxxxxxxxxxxxxxxxxxxxxx> <C9FBE74F.2D7EB%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Keir Fraser writes ("Re: [Xen-devel] [PATCH 00 of 45] gcc 4.6 compile fixes for 
> We should just disable the warning. Job done, don't need to take the uglier
> "fixes".

I don't think we really want lots of unused variables being assigned
to, do we ?  In some cases the function computing the value may be
doing pointless work and so this might even improve performance.

So I think -Wset-but-unused-variable is fine with -Werror too in the
long run but we'll have to have it with
-Wno-error-set-but-unused-variable (or whatever the syntax is) until
the compiler becomes widespread.


Xen-devel mailing list