WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 00 of 45] gcc 4.6 compile fixes for xen-unstable

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 00 of 45] gcc 4.6 compile fixes for xen-unstable
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 20 May 2011 09:28:10 +0100
Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 20 May 2011 01:29:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DD6369302000078000425E2@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1305831919@xxxxxxxxxxxx> <4DD6369302000078000425E2@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-05-20 at 08:38 +0100, Jan Beulich wrote:
> >>> On 19.05.11 at 21:05, Olaf Hering <olaf@xxxxxxxxx> wrote:
> > The following series fix compile errors with gcc 4.6.
> > Please review if each change is correct.
> 
> Hmm, this large amount of changes

I knew this warning would be trouble when I first saw it...

>  makes we wonder whether we
> shouldn't simply turn of the unused-but-set-variable warning
> altogether, or at least not have it be an error. Not the least
> because I'm not sure it'd be nice to backport all of these changes
> into older trees (which obviously would suffer mostly the same
> problems when built with 4.6 or newer).

Perhaps we should do both -- take the fixes into unstable and disable
the warning in 4.1?

Ian.

> 
> Jan
> 
> > Thanks,
> > 
> > Olaf
> > 
> >  tools/console/client/main.c                          |    3 --
> >  tools/debugger/gdbsx/gx/gx_comm.c                    |    2 -
> >  tools/firmware/rombios/32bit/tcgbios/tcgbios.c       |    2 -
> >  tools/libxc/xc_domain_restore.c                      |    2 -
> >  tools/libxc/xc_tmem.c                                |    3 --
> >  tools/libxl/libxl.c                                  |    6 ++---
> >  tools/libxl/libxl_dom.c                              |    4 +--
> >  tools/libxl/libxl_pci.c                              |    2 -
> >  tools/libxl/libxl_utils.c                            |    2 -
> >  tools/libxl/libxlu_cfg.c                             |    2 -
> >  tools/libxl/xl_cmdimpl.c                             |    5 ----
> >  tools/misc/gtraceview.c                              |    3 --
> >  tools/python/xen/lowlevel/checkpoint/libcheckpoint.c |    6 +----
> >  tools/python/xen/lowlevel/netlink/libnetlink.c       |    3 --
> >  tools/xcutils/xc_restore.c                           |    3 --
> >  tools/xenstat/xentop/xentop.c                        |    8 +------
> >  tools/xenstore/xenstored_core.c                      |   20 
> > ++++++++++++++-----
> >  xen/arch/x86/acpi/cpu_idle.c                         |    2 -
> >  xen/arch/x86/cpu/amd.c                               |    3 --
> >  xen/arch/x86/cpu/intel.c                             |    3 --
> >  xen/arch/x86/cpu/intel_cacheinfo.c                   |    7 ------
> >  xen/arch/x86/cpu/mcheck/mce.c                        |   15 +++-----------
> >  xen/arch/x86/cpu/mcheck/vmce.c                       |    2 -
> >  xen/arch/x86/hvm/emulate.c                           |    3 --
> >  xen/arch/x86/hvm/hvm.c                               |    5 +---
> >  xen/arch/x86/hvm/viridian.c                          |    5 ----
> >  xen/arch/x86/microcode_amd.c                         |    3 --
> >  xen/arch/x86/mm.c                                    |    2 -
> >  xen/arch/x86/mm/mem_sharing.c                        |    2 -
> >  xen/arch/x86/mm/p2m-pod.c                            |    3 --
> >  xen/arch/x86/mm/p2m.c                                |    2 -
> >  xen/arch/x86/mm/shadow/multi.c                       |    4 +--
> >  xen/arch/x86/msi.c                                   |    9 --------
> >  xen/arch/x86/time.c                                  |    5 ++--
> >  xen/arch/x86/x86_64/mm.c                             |    4 ---
> >  xen/common/cpupool.c                                 |    2 -
> >  xen/common/grant_table.c                             |    2 -
> >  xen/common/kexec.c                                   |    2 -
> >  xen/common/sched_credit2.c                           |    4 ---
> >  xen/common/tmem.c                                    |    4 +--
> >  xen/common/tmem_xen.c                                |    4 +--
> >  xen/common/unlzo.c                                   |    3 --
> >  xen/drivers/passthrough/vtd/intremap.c               |    6 -----
> >  43 files changed, 59 insertions(+), 123 deletions(-)
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx 
> > http://lists.xensource.com/xen-devel 
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel