This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xen

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c
From: Keir Fraser <keir@xxxxxxx>
Date: Fri, 20 May 2011 15:58:09 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Delivery-date: Fri, 20 May 2011 08:00:05 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to:cc :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=rs13rRJAO5H0IwzbaH+nXOiIQNRl/2X9fbem3HoC8RI=; b=etW3A4vq0v3rRV6rFjoH0tXBuIHu2/i3mOEiBBIGigeVpfxcU1ylW6+sDRTu0fU9li xF6qd815ohiJw6RUF87WcZqb7dvgBAEwPd2h181QcikjHMEuW+RJUzEa7fKuO2bQv08u Ji9sZzkpR6PMGbyyD1wvfscDza0o03FSq/vdg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=lc6Un3Tsncfx1ek6l2ZerBJlrVDkreuDT4vmYxeP7BVQnVa294vbEHlYLenb32apT6 waircvlGt0Ab+NWnLN2qjPUgwVsaoC6zZhSCgn+vO5PGonh1fHeN4NWMtqJkxh33iEKp Be0ZXRWQfyVlhF1G1HSzCq+h+cUkNXCt6lX+k=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110520143846.GA17222@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwW/lT4mGjL2HTfmES41ns87vB/sg==
Thread-topic: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c
User-agent: Microsoft-Entourage/
On 20/05/2011 15:38, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

> On Fri, May 20, Keir Fraser wrote:
>> On 20/05/2011 09:30, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:
>>>> I applied the first couple of these patches, but... We don't set
>>>> -Werror=unused-but-set-variable, so we don't actually need these fixes, do
>>>> we? Unless they are cleanups or fixes in some other way?
>>> gcc 4.6 adds it to the default set of Werrors.
>> I'll take a patch from someone to remove it from the default set, please.
> I will send a tested patch.
> It may hide some bugs. In one of the patches for tools/ some function
> returns 0 unconditionally instead of the rc variable.

Oh dear. Well, the tools/libxl maintainers are free to keep the new
warnings, and take your fixes, if they wish, clearly needing the help. ;-)

 -- Keir

> Olaf

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>