This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xen

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Fri, 20 May 2011 16:38:46 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Delivery-date: Fri, 20 May 2011 07:39:41 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1305902332; l=632; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=SIbOnf+9a4khc2Itq/pw/Y9xEwg=; b=TF5LxTZonTW3EVys88vTp+aIzB7XAorfj3TepVhy5kmOybHESaD4xskrNnESueSvoEm ywxN0i7l66xAagDbUd53mB4vm4zJ3CO2Ikj6VKV1v7MRGsVq+7KzkFsEzZ7mAatdI74fc lQ0ksCfr8JPRBvlVWaMGbmZj+TDWJ94w+Lw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C9FBE7CE.2D7EC%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1305880225.20576.2.camel@xxxxxxxxxxxxxxxxxxxxxx> <C9FBE7CE.2D7EC%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, May 20, Keir Fraser wrote:

> On 20/05/2011 09:30, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:
> >> I applied the first couple of these patches, but... We don't set
> >> -Werror=unused-but-set-variable, so we don't actually need these fixes, do
> >> we? Unless they are cleanups or fixes in some other way?
> > 
> > gcc 4.6 adds it to the default set of Werrors.
> I'll take a patch from someone to remove it from the default set, please.

I will send a tested patch.

It may hide some bugs. In one of the patches for tools/ some function
returns 0 unconditionally instead of the rc variable.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>