This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 10/14] docs: update xl-disk-configuration.txt to

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 10/14] docs: update xl-disk-configuration.txt to describe new syntax
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Fri, 20 May 2011 10:27:23 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 20 May 2011 02:29:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19923.40954.556919.444777@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1305211004-31687-1-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-2-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-3-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-4-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-5-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-6-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-7-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-8-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-9-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-10-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-11-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305290747.31488.113.camel@xxxxxxxxxxxxxxxxxxxxxx> <19923.40954.556919.444777@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2011-05-18 at 11:31 +0100, Ian Jackson wrote:
> > > +where each diskspec is in this form:
> > > +
> > > +   [<key>=<value>|flag]*,
> > > +     [<target>, [<format>, [<vdev>, [<access>]]]],
> > > +     [<key>=<value>]*,
> > > +     [target=<target>]
> > 
> > The actual meaning of this is pretty opaque. The paragraphs following
> > "More formally" does a pretty good job of describing it but I still have
> > a few questions/misunderstandings.
> Do you think I should get rid of this template ? 

I think it would be ok if you correct the * placements etc. Having some
sort of (semi-)formal syntax declaration in addition to the wordy
description is useful IMHO.

Would the syntax be clearer as a BNF style thing rather than a regexp-y
thing? e.g. this would allow "[<target>, [<format>, [<vdev>,
[<access>]]]]," to be declared as "POSITIONAL_PARAMETERS := ..." making
the syntax a little more self-documenting and "KEY := ..." could be
defined with reference to the relevant following sections etc.

Should the second "<key>=<value>" usage also have a "|flag"?

I presume "key" can also == "target" and can be the non-ultimate key so
long as the value does not contain any problematic characters. In this
case the explicit target= needs to be marked as optional.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>