This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 08/14] libxl: disks: new xlu_disk_parse function

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 08/14] libxl: disks: new xlu_disk_parse function
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 13 May 2011 11:48:26 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 13 May 2011 03:49:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1305211004-31687-9-git-send-email-ian.jackson@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1305211004-31687-1-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-2-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-3-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-4-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-5-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-6-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-7-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-8-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1305211004-31687-9-git-send-email-ian.jackson@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-05-12 at 15:36 +0100, Ian Jackson wrote:
> [...]
> +void xlu__disk_err(DiskParseContext *dpc, const char *erroneous,
> +                   const char *message) {
> +    fprintf(dpc->cfg->report,
> +           "%s: config parsing error in disk specification: %s"
> +            "%s%s%s"
> +            " in `%s'\n",
> +           dpc->cfg->filename, message,
> +            erroneous?": near `":"", erroneous?erroneous:"", 
> erroneous?"'":"",
> +            dpc->spec);

Something seems to be up with the leading whitespace here.

> +   * Normally one would pass nspecs==1 and only specs[0].  But it is
> +   * permitted to pass more strings in which case each is parsed as a
> +   * string containing a collection of parameters (but they all refer
> +   * to of the configuration for a single disk).

           ^^ what is that doing there?

I don't really speak enough flex to have a proper opinion but it looks
plausible enough to me so:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

This is the third time this week I've wondered if a patch ought to come
along with a library of test inputs and expected outputs. I'll be
proposing we switch to the waterfall model before you know it...

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>