WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH/RFC 00/14] libxl: disk configuration handling

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH/RFC 00/14] libxl: disk configuration handling
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 13 May 2011 11:33:39 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 13 May 2011 03:34:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1305211004-31687-1-git-send-email-ian.jackson@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1305211004-31687-1-git-send-email-ian.jackson@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-05-12 at 15:36 +0100, Ian Jackson wrote:
> This is the latest version of my disk config parsing patch series.
> 
> 00-04  Hopefully uncontroversial cleanups and minor features.

For these:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Although I'm not sure about the benefit of #4, it is consistent with
e.g. free() accepting NULL so why not.

> 05-07  Preparatory work.
> 08-10  The new parser and its documentation.
> 11-12  Replace old parsers with calls to the new one.
> 13-14  Two features, one of them essential.
> 
> The use of the pcre library is gone; everything is done with flex now.
> The result is reasonably clean.
> 
> You can see how it improves the approach needed for addition of new
> features to the disk config syntax by looking at patch 13, which is
> precisely such a new feature.  In patch 13 everything but the change
> to libxlu_disk_l.l is autogenerated, so it is that subset that is the
> relevant change.
> 
> I'd like to apply as many of these as I can get acks for :-).
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel