 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] Xen security advisory CVE-2011-1898 - VT-d (PCI passthro
| To: | Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "Cihula, Joseph" <joseph.cihula@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] Xen security advisory CVE-2011-1898 - VT-d (PCI passthrough) MSI |
| From: | Keir Fraser <keir.xen@xxxxxxxxx> |
| Date: | Wed, 18 May 2011 11:03:48 +0100 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Wed, 18 May 2011 03:06:06 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=xiTRjAjDxH4pNepMHya3Yf/LEwgu1+Rr0t3EwjS1aSo=; b=En1HvF5Cq08ZQl3GZxjo0EcPJrg/qXdt35jgLoxx4IdIGFasCOk5iL3GJmnlmmGLVs WSleyxspS9qG0x36JrcZWZN3Hwh81gv7lP2G4LdMmRd+4G0K7kz8dKgOFUl0CQddQM+g 7E1tXGGnnQPTr38sr1P7SJgGNB+2rmKGHScBg= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=IyDgLjXOYvaZT9bWcMZGx0mY55Ws2vszhR7LRt2dGcR5wgJZot/DhZyn24kcnWDjrL v+cKCMdWqjcrXntXFGSq+zF0mtvKbnF6CmH6fYG3qmYmFH1ETC2I8dN0WsEQAC9tmf4d NdX6YUU8TP2wOWRFemIqj+qnlPOdeOiWTIv9Y= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1305708829.20907.108.camel@xxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcwVQuFedsuqf46rFEuDxTGWVWeR9Q== |
| Thread-topic: | [Xen-devel] Xen security advisory CVE-2011-1898 - VT-d (PCI passthrough) MSI |
| User-agent: | Microsoft-Entourage/12.29.0.110113 |
On 18/05/2011 09:53, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> On Mon, 2011-05-16 at 22:34 +0100, Cihula, Joseph wrote:
>>> - if ( iommu_intremap )
>>> - {
>>> +
>>
>> Unless I'm misreading it, this will prevent users from specifying
>> "no-intremap" to disable the use of IR.
>
> That wasn't my intention.
>
>> Why would you keep the 'if ( iommu_intremap )' on the previous code
>> block but remove it here?
>
> To be honest this change was a little bit unrelated, which was naughty
> of me. I saw:
> if ( iommu_intremap ) {
> THING A
> }
> if ( iommu_intremap ) {
> THING B
> }
> and changed it to
> if (iommu_intremap ) {
> THING A
> THING B
> }
>
> Is there some subtlety to this code path that I've missed?
'THING A' conditionally clears iommu_intremap.
-- Keir
> Ian.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: | [Xen-devel] [PATCH] x86: clear CPUID output of leaf 0xd for Dom0 when xsave is disabled, Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-devel] Xen security advisory CVE-2011-1898 - VT-d (PCI passthrough) MSI, Ian Campbell |
| Previous by Thread: | RE: [Xen-devel] Xen security advisory CVE-2011-1898 - VT-d (PCI passthrough) MSI, Ian Campbell |
| Next by Thread: | Re: [Xen-devel] Xen security advisory CVE-2011-1898 - VT-d (PCI passthrough) MSI, Ian Campbell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
