WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Xen security advisory CVE-2011-1898 - VT-d (PCI passthro

On Mon, 2011-05-16 at 22:34 +0100, Cihula, Joseph wrote:
> > -    if ( iommu_intremap )
> > -    {
> > +
> 
> Unless I'm misreading it, this will prevent users from specifying
> "no-intremap" to disable the use of IR.

That wasn't my intention.

> Why would you keep the 'if ( iommu_intremap )' on the previous code
> block but remove it here?

To be honest this change was a little bit unrelated, which was naughty
of me. I saw:
        if ( iommu_intremap ) {
                THING A
        }
        if ( iommu_intremap ) {
                THING B
        }
and changed it to 
        if (iommu_intremap ) {
                THING A
                THING B
        }

Is there some subtlety to this code path that I've missed?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>