This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynam

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Wed, 13 Apr 2011 09:32:10 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Ian.Campbell@xxxxxxxxxx, Tim.Deegan@xxxxxxxxxx
Delivery-date: Wed, 13 Apr 2011 06:34:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C9CB2168.2C9D6%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110412172140.GA13007@xxxxxxxxxxxx> <C9CB2168.2C9D6%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Apr 13, 2011 at 09:46:15AM +0100, Keir Fraser wrote:
> On 12/04/2011 18:21, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx> wrote:
> > On Tue, Apr 12, 2011 at 02:06:05PM +0100, Keir Fraser wrote:
> >> On 12/04/2011 13:53, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx> 
> >> wrote:
> >> 
> >>>> How cunning.
> >>>> 
> >>>> Why wouldn't you just allocate exactly the right size of array in
> >>>> XENMEM_set_memory_map?
> >>> 
> >>> I was thinking about it, but the mm.c code did not have the
> >>> xen/xmalloc.h header, nor any references to xmalloc_array.
> >>> 
> >>> Is it OK to make an xmalloc_array during a hypercall?
> >> 
> >> Yes. I think the toolstack should be able to clean up on the newly-possible
> >> ENOMEM return from this hypercall.
> > 
> > Hm, not sure what I am hitting, but I can't seem to be able to copy over the
> > contents to the newly allocated array from the guest (this works
> > fine with the previous version of the patch). This is what I get
> Your patch is not really quite right. I've attached a modified version for
> you to try.

Excellent, and it works quite nicely. Thank you.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>