This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 3 of 4] libxl: Add support for passing in the mac

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 3 of 4] libxl: Add support for passing in the machine's E820 for PCI passthrough in libxl_device_pci_parse_bdf
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Tue, 12 Apr 2011 13:19:43 +0100
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, "keir.fraser@xxxxxxxxxxxxx" <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 12 Apr 2011 05:20:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <75e24fb720fa9a1c529b.1302557733@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1302557730@xxxxxxxxxxxxxxxxxxxxxxx> <75e24fb720fa9a1c529b.1302557733@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2011-04-11 at 22:35 +0100, Konrad Rzeszutek Wilk wrote:
> The code libxl_device_pci_parse_bdf calls the libxl__e820_alloc when
> it has parsed one BDF. Subsequent calls to libxl_device_pci_parse_bdf
> will
> not trigger libxl__e820_alloc being called (unless the first call to
> libxl__e820_alloc failed).

That sounds like a very odd non-intuitive location for that allocation.
Why not do it in libxl_domain_create or somewhere like that?

I think the e820 map added to the idl should become a simple boolean
flag and this should all be taken care of internally based on that.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>