This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynam

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Wed, 13 Apr 2011 09:31:54 -0400
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir@xxxxxxx>, Ian.Campbell@xxxxxxxxxx, Tim.Deegan@xxxxxxxxxx
Delivery-date: Wed, 13 Apr 2011 06:32:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DA56E1C020000780003B4CA@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110412125317.GA19198@xxxxxxxxxxxx> <C9CA0CCD.2C923%keir@xxxxxxx> <20110412172140.GA13007@xxxxxxxxxxxx> <4DA56E1C020000780003B4CA@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
> ... this "else". If you have an e820 table already, and it's too small,
> you want to not only free it, but also allocate a new one. So
> instead of an "else" you'll need a second "if" here, recovering from
> the table possibly having got freed. Since xfree(NULL) is okay, you
> could actually simply use the inner conditional on the first check.

Grrr.. Right. How embarrassing - I will blame it on the lack of sleep.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>