This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH V3] AMD IOMMU: Fix an interrupt remapping issue

>>> On 11.04.11 at 12:31, Wei Wang2 <wei.wang2@xxxxxxx> wrote:
> This patch is the latest. Should have addressed all of your concerns. Please 
> take a look.

Looks good to me now. Assuming it also still addresses the problem
at hand:
Acked-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Thanks, Jan

> Thanks,
> Wei
> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> On Monday 11 April 2011 09:23:38 Jan Beulich wrote:
>> >>> On 08.04.11 at 18:52, Wei Wang2 <wei.wang2@xxxxxxx> wrote:
>> >
>> > Jan, How dose this one look like to you?
>> Much better, but still not quite there: The unmasking must happen
>> *after* the writing of the upper half (if that's what is being modified).
>> You could also skip the unmasking altogether if saved_mask == 1.
>> And if you start using __io_apic_write() (which I find very desirable)
>> is there a reason not to use it (and __io_apic_read()) in all of the
>> other places you touch anyway, too?
>> Jan

Xen-devel mailing list