WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] AMD IOMMU: Fix an interrupt remapping issue (v2)

>>> On 08.04.11 at 18:52, Wei Wang2 <wei.wang2@xxxxxxx> wrote:
> Jan, How dose this one look like to you?

Much better, but still not quite there: The unmasking must happen
*after* the writing of the upper half (if that's what is being modified).

You could also skip the unmasking altogether if saved_mask == 1.

And if you start using __io_apic_write() (which I find very desirable)
is there a reason not to use it (and __io_apic_read()) in all of the
other places you touch anyway, too?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel