This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxl: new xlu_disk_parse function

Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] libxl: new xlu_disk_parse 
> On Mon, 28 Mar 2011, Gianni Tedesco wrote:
> > Hmm, I'm not sure this is nicer than the code it's replacing, it's
> > certainly a lot longer. I don't like the idea of it being full of things
> > comparing for ",w" or ":cdrom" etc, rather than tokenising it fully and
> > evaluating what the tokens are separately.
> I definitely agree.
> Besides when doing refactoring the code produced should be either shorter or
> at least easier to read but this code is neither of them.

I agree that as a rule of thumb better code is shorter.  Unfortunately
string parsing in C is one of those exceptions.

What I was trying to do was to separate out the actual syntax in a way
that is reasonably tractable, and which is amenable to being edited
later without introducing bugs.

So while the current code is longer in this case I think it's clearer.
A good deal of the added code is very simple and straightforward "set
up this regexp engine and check the return value".

It is a shame that the syntax is so abstruse.  We can do better with
the nic parameters which have a better syntax.


Xen-devel mailing list