This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxl: new xlu_disk_parse function

Please trim your quotes guys!

On Mon, 2011-03-28 at 19:13 +0100, Stefano Stabellini wrote:
> On Mon, 28 Mar 2011, Gianni Tedesco wrote:
> Besides when doing refactoring the code produced should be either shorter or
> at least easier to read but this code is neither of them.

Without reference to this specific patchset I disagree with "shorter"
here. The important things are clarity, maintainability, correctness etc
(and possibly performance depending on circumstances).

Brevity is a poor indicator for any of these (or anything really, unless
you are playing Perl golf) although it may be a partial factor in some
of them.

It is perfectly possible that a refactoring doubles the number of lines
of code yet is still a clear improvement.


Xen-devel mailing list