This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] remus: fix check for installed qdiscs on ifb

On Thu, Mar 31, 2011 at 10:07 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
Shriram Rajagopalan writes ("Re: [Xen-devel] [PATCH] remus: fix check for installed qdiscs on ifb"):
> sorry. my bad. It is not the pre-existing qdiscs that cause an
> issue. It is caused by the dummy "mq" qdisc that gets added by
> "default". The original code checks for presence of only
> ingress/pfifo-fast qdisc. If anything else is present, it punts. In
> this case, "mq" is present (added by default) and causes remus to
> fail.

Thanks for the explanation.  I confess I still don't really understand
why other qdiscs besides the default ones are a problem, but the
default ones aren't, but I think your patch isn't making anything
worse so I have applied it.

So, if there is multiqueue support in the system, then mq becomes
one of the default qdiscs that could be found on an interface.
And this patch basically adds mq to the list.
Thanks for applying the patch

Xen-devel mailing list