This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] remus: fix check for installed qdiscs on ifb

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] remus: fix check for installed qdiscs on ifb
From: Shriram Rajagopalan <rshriram@xxxxxxxxx>
Date: Sat, 19 Mar 2011 20:39:50 -0700
Delivery-date: Sat, 19 Mar 2011 20:40:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.4.3
# HG changeset patch
# User Shriram Rajagopalan <rshriram@xxxxxxxxx>
# Date 1300592358 25200
# Node ID 87f94f4f06c4403b97c4fd4d81e3ddc29e17f88a
# Parent  a8fee4ad3ad0650e7a5cc0fb253c6a0ada1ac583
remus: fix check for installed qdiscs on ifb

current check includes ingress and pfifo_fast.
Add mq to the list of allowed qdiscs already installed
on ifb. This patch fixes cases where remus fails to start,
due to an mq qdisc already present on the vif.

Signed-off-by: Shriram Rajagopalan <rshriram@xxxxxxxxx>

diff -r a8fee4ad3ad0 -r 87f94f4f06c4 tools/python/xen/remus/device.py
--- a/tools/python/xen/remus/device.py  Fri Mar 11 18:22:23 2011 +0000
+++ b/tools/python/xen/remus/device.py  Sat Mar 19 20:39:18 2011 -0700
@@ -320,9 +320,9 @@
             if q['kind'] == 'plug':
                 self.installed = True
-            if q['kind'] not in ('ingress', 'pfifo_fast'):
+            if q['kind'] not in ('ingress', 'pfifo_fast', 'mq'):
                 raise BufferedNICException('there is already a queueing '
-                                           'discipline on %s' % devname)
+                                           'discipline %s on %s' % (q['kind'], 
         print ('installing buffer on %s... ' % devname),
         req = qdisc.addrequest(self.bufdevno, self.handle, self.q)

Xen-devel mailing list