This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] xen-unstable: build fails

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] xen-unstable: build fails
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Thu, 17 Mar 2011 10:55:30 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 17 Mar 2011 03:56:14 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=cWW4L0nGOOvM1hwP1ZqHLkCAnLEoHEM1ms81MR/ceZE=; b=Jc/NdJkLpWUQoh6mMe66juwjuX+EHs21Mc1lcj9RPyEvL4W4fszcuAEmouW8NNKfx4 vg3r0504Cz5KA2Bk9IKAJjEqSD+Uf0IulQDrMozS4M0kDX0ufYw1MAb1AcMSDkrayjBl pclLgRM4XboEi62ieWBEBLwmpvLJTzBo0qnMw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=FYe6GHFFD+jPDkqJFGBYGxwUixIkenX5hx1/7vtNdD8g5imO3W+WBzWb8oGowW9Au8 b9QWR0x9YRDH/KbZhfbkcAewYwqzMQdSKj0qWhBSKXxGRMihwXt4s+0bR+dvl78sc1aI SDl47MPCgfo9QeyhgN80OGqLdaksZ8717IYyA=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D81F4F702000078000370BB@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcvkkdSxaccYe8lPz0iiVcO303puqg==
Thread-topic: [Xen-devel] xen-unstable: build fails
User-agent: Microsoft-Entourage/
On 17/03/2011 10:48, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> As short time measure this seems to be okay.
>> On the long run I'd prefer to use absolute paths only. Otherwise you've
>> always a risk to use something from outside the intended build environment.
>> XEN_ROOT = $(abspath ../..)
>> seems not too hard to use instead of
>> XEN_ROOT = ../..
> Except that make 3.80 doesn't support this, and that make version
> is - to my knowledge - still in quite wide spread use. But that can
> probably be overcome with a fallback implementation (which newer
> make just wouldn't use).

It has CURDIR, so we can just use that. Which is what I've done. It's also
cleaned up some not-nice bit of build-fu which were prefixing a relative
XEN_ROOT with arbitrary extra ../'s to "make things work".

 -- Keir

Xen-devel mailing list