This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] xen-unstable: build fails

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] xen-unstable: build fails
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Wed, 16 Mar 2011 16:50:32 +0000
Delivery-date: Wed, 16 Mar 2011 09:52:53 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=OfW6M5mGr2M6dXUj2tM0+tHC39MntfXM8KNTh4UKZ3E=; b=se/7bJdPswWUszyH3VBqVrCSf21oxV5ks7uGbK48vAVazpsZDeJyYshlMyKroYX3YN s1G5E25aRwemBEidrZeWOwdzkp6exEfmstH6QH+mFiQun/LDMeBdLNJYcmUgCJGgJHjl GVT0cuWyR/0EnIhYuUSS24HntoD0lhqX1BBoQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=wu4gozB85Chw/Y8JZ+ySxpjCdjHcJuaDS2WDxuqcfNjYgrnb8BUsWmR6cdwwUndhQ+ mFcRAaBCewkvniQqUQZ4bEGauVarwnEM1pG+Qr2bRHhvAWsZpq7CIiJqK7bogjzhy8F/ 3/V0Odq4q27CU+tL8Po72MAkGb0Zypphwq+mU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D80C037.5010602@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acvj+kNDK0v+eEgCcEmY3NG5gNYbAw==
Thread-topic: [Xen-devel] xen-unstable: build fails
User-agent: Microsoft-Entourage/
On 16/03/2011 13:50, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:

> Hi,
> I've just set up a machine with OpenSuse 11.4 and tried to build Xen.
> Under root I did:
> hg clone http://xenbits.xensource.com/xen-unstable.hg
> cd xen-unstable.hg
> make xen
> The make failed with:
> make[4]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> RELOC=0x7c000 make -f build32.mk reloc.S
> make[5]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
> make[5]: *** ../../../../.config: Is a directory.  Stop.

Seems to me that /root/xen-unstable.hg/xen/arch/x86/boot/../../../../.config
resolves to /root/xen-unstable.hg/.config. Which is what is intended. Also I
tried creating a .config dir just outside my own xen-unstable repo, and
rebuoilding the hypervisor, and it works okay for me.

> The reason seems to be a directory /root/.config which isn't present on my
> other machines.

We shouldn't be referring outside the repository. AFAICS the above logging
doesn't indicate that we are. I don't understand why you are getting that
error. I haven't been able to reproduce it.

> fails in a similar way. Many Makefiles seem to contain lines like:
> XEN_ROOT=../..
> which is a really bad idea in my opinion. XEN_ROOT should only be set, if it
> is not yet defined.

Why? It's private to our build system. We don't want the user screwing with
it. I also don't see why relative paths within our repository should be
avoided, as you try to do in your alternative formulation.

 -- Keir

> I'd suggest to use
> XEN_ROOT ?= $(PWD)/../..
> instead. A patch is easily made, but affects ca. 100 Makefiles. And this
> change could break the possibility to just do a "make" in a subdirectory.
> Opinions?
> Juergen

Xen-devel mailing list