This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] xen-unstable: build fails

To: Keir Fraser <keir.xen@xxxxxxxxx>
Subject: Re: [Xen-devel] xen-unstable: build fails
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date: Thu, 17 Mar 2011 09:59:54 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 17 Mar 2011 02:01:19 -0700
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1300352397; x=1331888397; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=IerAT1oAxapdtLJ1Wo6k88wgK6SlEPxyiUzVc1ePgV8=; b=jZHPH82BLHTIHDbQROJdVEW1K6HP/UDrXN3QyAdGj9IU87nsaxtLu9NO KgKpN8Hgb4inuKDkzWnoB2a4mhvxdmJuEbhs9lIoN8uwZz9o44mhmuwaz mJIzIkj88KHE+Mo7Ty0/FqodQpIYUMn5HRBeL7JqWyF26rSly2vmkTpJ+ lsCajgYL5iPvbOYSFeX/JqGu1eW+VXkH73xqoZy0tzjGJPmIzsFemE8i1 u6uX9yA7TvKPR1socMA6XAtjO1aR7;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=XveLAXBZlInj1QMz/wudjUsCIkFpwaA97uH95sV5eETlVL6fdfA8zmkX YecGhLSyzumWClR+KVIz/eikZ+SsHHfzVFv8fKL2LdtSxc7uZE5G+Q9Fz Az2Z4u4RDB0IQ38rrp7AhIHXVOSVIPMFHBmHtQnI7ezLl64rMI2L4Y7SF E8zWvlwfhJkDNTk5Rwq9n30WUJwRyBFoxZmV5c7V5ewCJDv5062lp1Ipd MucHmLk0gV44XhY+J+VUxrXXUiofR;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C9A772CD.14F43%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Technology Solutions
References: <C9A772CD.14F43%keir.xen@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101226 Iceowl/1.0b1 Icedove/3.0.11
On 03/17/11 09:11, Keir Fraser wrote:
On 17/03/2011 05:52, "Juergen Gross"<juergen.gross@xxxxxxxxxxxxxx>  wrote:

The reason is clear: XEN_ROOT is set to a *relative* path. And when make is
including a Makefile, it switches the working directory to the directory of
the included Makefile. Including another Makefile via XEN_ROOT then is the

Well it's not clear to me. In my tests, including another Makefile does not
change the working directory, only recursive make with -C specified does
that. That seems logical -- pulling in standard rules containing wildcard
globs would otherwise have unpredictable results, if the wildcards were
evaluated in the directory of the included Makefile.

In your case, if Config.mk was getting run with incorrect relative XEN_ROOT,
how would the earlier include lines in that file work? You are getting an
error on '-include $(XEN_ROOT)/.config', but there are earlier (and
unconditional!) include lines in Config.mk that also reference XEN_ROOT. I
suppose they must be working.

So I think something is weird in your environment, or your make is broken.
However in this one specific failure case I can avoid redefining XEN_ROOT
outside xen/Makefile, since all hypervisor builds start at that Makefile. So
you can see whether c/s 23048 in xen-unstable staging fixes your build. I
applied it as it happens to be a teeny tiny cleanup as well.

We are both right :-)

I created /.config with:

$(warning /.config: $(MAKEFILE_LIST))

and got the following with "make tools":

make -C tools install
make[1]: Entering directory `/root/xen-unstable.hg/tools'
make[2]: Entering directory `/root/xen-unstable.hg/tools'
make -C check install
make[3]: Entering directory `/root/xen-unstable.hg/tools/check'
../../.config:1: /.config: Makefile ../../tools/Rules.mk ../../Config.mk ../../config/Linux.mk ../../config/StdGNU.mk ../../config/x86_64.mk /usr/include/../../.config

So the problem is not changing the working directory, but implicit directory
search. $(XEN_ROOT)/.config expands as ../../.config and this file was not
found, so make searches in /usr/include, as the file path is relative. And
/usr/include/../../.config results as /.config :-(

The problem is still the relative XEN_ROOT specification.
Or the missing .config under XEN_ROOT, so creating this file solves my
problem. :-)


Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Xen-devel mailing list