This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: xenstore index reset in xb_init_comms breaks domU kdump

To: Keir Fraser <keir@xxxxxxx>
Subject: [Xen-devel] Re: xenstore index reset in xb_init_comms breaks domU kdump
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Wed, 26 Jan 2011 15:30:47 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 26 Jan 2011 06:31:32 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1296052253; l=801; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=B5YvW5+pWXqx81kfSgijPRyUfBA=; b=oGJxhVJuyRSauojE1gj33xXuYcldMnPqq7Qjd3CQudlGvUDyP14ArMYXwhRSMdveMwN CQfMnW3IsJQFoeNLL3hIPkzTGYLZ2/1UqR1ejWQuC/3YrMSUBnvutJpIm238BdjhL9fAC 3yrossXo3yZeXX9ItvI1Jw90Bik53Oph46w=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C965DE5E.127A2%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110126140043.GA27631@xxxxxxxxx> <C965DE5E.127A2%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Jan 26, Keir Fraser wrote:

> I think it is needed for save/restore. It may not be needed during boot
> though. Your safest (lowest impact) fix would be to skip the reset when
> booting a crash kernel. A kernel knows it is a crash kernel, I believe?

There is is is_kdump_kernel(), which relies on an unexported variable.
However, the kdump tool in SLES11 passes 'reset_devices' in cmdline. And
this variable is exported and used in a few drivers to do extra hardware
reset. My patch adds a if (!reset_devices) before the assignment.

reset_devices was added in commit
7e96287ddc4f42081e18248b6167041c0908004c and appeared in 2.6.19. Its not
yet part of linux-2.6.18-xen.hg, it should be easy to backport.

I will post my SLES11 SP1 version of the kdump patch shortly.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>