This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] xenstore index reset in xb_init_comms breaks domU kdump

To: Keir Fraser <keir@xxxxxxx>
Subject: [Xen-devel] xenstore index reset in xb_init_comms breaks domU kdump
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Wed, 26 Jan 2011 15:00:44 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 26 Jan 2011 06:01:59 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1296050456; l=831; s=domk; d=aepfle.de; h=Content-Type:MIME-Version:Subject:Cc:To:From:Date:X-RZG-CLASS-ID: X-RZG-AUTH; bh=U9OB20cIy6a7s8SAS/AD4VK7tXA=; b=J9vQ2Kmlo98W6VCAgVIcW/vV59wxxnPSClMzyJBFI2NwiFJ7shDnLxv8NuIW2RKTBB9 KAmj2I+dtCjtTC2Gyu91wHt6uAw/+tTYJw6RrAoeUCxL0zbCB+h/Zn5UnLhCX1i8WA89U za7JEpAPmLfJhhccDyHCN6UYOpYWUOe8YeQ=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)

in the commit below a reset of the rsp_cons/rsp_prod index was added.

Is this reset really required for save/restore? I have not tried it, but
I would assume a restored guest would get an empty page to work with.
Could a guest be saved when its in the middle of a xenstore operation?

The reset breaks the xenstore interface in a crashed domU kernel. If the
crash kernel boots, it tries to operate on the new rsp_* index. But this
contains garbage, process_msg() tries to use the data as 'struct
xsd_sockmsg', and kmalloc() fails.
If I remove the rsp_cons/rsp_prod reset in xb_init_comms(), the PV
drivers in the crash kernel can connect to xenstore.

Should the fixup code be removed, or is it essential for save/restore?


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>