This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xl: Check for dependencies in xl

To: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xl: Check for dependencies in xl
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 21 Jan 2011 17:34:49 +0000
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 21 Jan 2011 09:35:32 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTikhHBX9L5-G7=SNS4DX58+1HQcXSNpgnJAawENT@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <AANLkTinm+Y1EE-4zaDyzm8m2gNbzt20MMpb9ypo=Geb9@xxxxxxxxxxxxxx> <1295027507.25342.956.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTimEu-and-4aaMUn+snhxS=cViKWweH6Jnbxpv10@xxxxxxxxxxxxxx> <1295032746.12280.110.camel@xxxxxxxxxxxxxxxxxxxxx> <AANLkTi=B-WgKZRemBh9Z_OL_mNjZyfpBokuVC-xQ2Y_d@xxxxxxxxxxxxxx> <AANLkTinH1t-Mc3nr+k-cabYhxw5z3rOBwAFMde3CJBKF@xxxxxxxxxxxxxx> <alpine.DEB.2.00.1101201100440.7277@kaball-desktop> <AANLkTikhHBX9L5-G7=SNS4DX58+1HQcXSNpgnJAawENT@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Kamala Narasimhan writes ("Re: [Xen-devel] [PATCH] xl: Check for dependencies 
in xl"):
> My preference would to use static const over preprocessor definitions
> but I also don't mind conformance if that is why you are suggesting
> this change.

Thanks, I would have applied this patch, but:

> +
> +    if ( stat(XENSTORE_PID_FILE, &stat_buf) != 0 ) {
> +        LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
> +            "Is xenstore daemon running?\nStat on file %s returned -
> \"%s\".\n",
> +            XENSTORE_PID_FILE, strerror(errno));
> +        return ERROR_FAIL;
> +    }

This part has been word-wrapped.  You need to send patches in a way
which does not word-wrap them.

And ideally you should probably use C99 string concatenation to split
the string so as to avoid the long line.


Xen-devel mailing list