This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xl: Check for dependencies in xl

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xl: Check for dependencies in xl
From: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>
Date: Fri, 14 Jan 2011 14:33:44 -0500
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 14 Jan 2011 11:34:18 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=06Er7EsVUOiU08/TzfYuqyY275bge+Gaqe3eLN1tF+4=; b=W/Z+3jnMYkBBtTXinEOThg+0fAzlsyQT/A60vCvwmQH/sWDClaC3X3Sh1Dzc58luqp +3yGQMvWHqP4cIPjBq6GFKh5mkzcxooCB7kwbtCoxcY/kPA1TIIPUSkrPZPDOrVpXIwf F1L6KeUMI8w/D2zGCNJYYlKYS7Vvg9m8vZ8Vw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=g7BgglfT6bzohTcWKdXKWdryG0nz2kF+/A+OsKe6vw3wBxZI6iTZ9DuSioyubAPqKf IZkQGu2m78EmmD5mdVA0s19OUoxzAzfXlHyB+FwsP6hggoFWIDdS+Jyue3bYW/fCNM5H maCPK4FNpCvxLPqiI8/KLbX21fQxpmEdzco8U=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1295032746.12280.110.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTinm+Y1EE-4zaDyzm8m2gNbzt20MMpb9ypo=Geb9@xxxxxxxxxxxxxx> <1295027507.25342.956.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTimEu-and-4aaMUn+snhxS=cViKWweH6Jnbxpv10@xxxxxxxxxxxxxx> <1295032746.12280.110.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> You mean "libxl_ctx_init would always be..."?

Yes, sorry.

> In that case yes since that it is the function contains opens the
> connection to xenstore so it must be called first. A libxl user
> shouldn't need to see or use xenstore directly itself since libxl
> encapsulates this.
> xtl_createlogger_stdiostream does/can not use xenstore since it comes
> from libxc which is beneath (or perhaps alongside) libxenstore in the
> software stack.
>> 2)  There aren't likely to be other dependency checks to be added in
>> future that might warrant a separate function to perform such checks?
> It's not clear what other checks there will end up being but those which
> are due to libxl's dependencies (e.g. xenstore) should be in a libxl
> function. This could be a separate libxl_check_dependencies() but I
> can't see any reason not to do it in libxl_ctx_init().
> If xl has some dependency of its own independent of libxl which it is
> useful to check then it would be appropriate to add those checks to xl
> itself.

Since this toolstack is new to me, as you might have observed from the
previous threads, I didn't differentiate between libxl/xl etc. (in
terms of where the changes end up) while writing those patches and
piling it all up as one unit :)   Now that I understand, I will make
the necessary changes.


Xen-devel mailing list