Re: [Xen-devel] [PATCH V3 3/6] xen, Intruduce pmtimer_change_ioport and HVM_PARAM_ACPI_NEW_IOPORT.

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Fri, 29 Oct 2010, Keir Fraser wrote:

> On 29/10/2010 13:08, "anthony.perard@xxxxxxxxxx" <anthony.perard@xxxxxxxxxx> 
> wrote:
> > By default, Xen will handle the old ACPI IO port. But it can switch to
> > the new one by setting the HVM_PARAM_ACPI_NEW_IOPORT to 1.
>
> Fine, but this new parameter deserves a better explanatory comment in
> include/public/hvm/params.h. Its meaning is subtle and not immediately
> obvious. So go into some detail -- that it is basically a version number,
> current valid versions are 0 and 1, and the effect of setting each of those
> valid version numbers. Note that some other parameters have maybe half a
> page of accompanying explanatory comment. It's better to write a bit too
> much rather than too little, and ensures our interface is well documented
> and hence well used and maintained, because others will understand it.
>
> Apart from this one point, I am happy for the entire patch series to be
> checked in. So once you've made that improvement:
> Acked-by: Keir Fraser <keir@xxxxxxx>

Thanks, I will do that!

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel