This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH V3 3/6] xen, Intruduce pmtimer_change_ioport and

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH V3 3/6] xen, Intruduce pmtimer_change_ioport and HVM_PARAM_ACPI_NEW_IOPORT.
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Fri, 29 Oct 2010 14:09:19 +0100 (BST)
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 29 Oct 2010 06:10:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C8F07BDF.89EB%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C8F07BDF.89EB%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 1.10 (DEB 962 2008-03-14)
On Fri, 29 Oct 2010, Keir Fraser wrote:

> On 29/10/2010 13:08, "anthony.perard@xxxxxxxxxx" <anthony.perard@xxxxxxxxxx> 
> wrote:
> > By default, Xen will handle the old ACPI IO port. But it can switch to
> > the new one by setting the HVM_PARAM_ACPI_NEW_IOPORT to 1.
> Fine, but this new parameter deserves a better explanatory comment in
> include/public/hvm/params.h. Its meaning is subtle and not immediately
> obvious. So go into some detail -- that it is basically a version number,
> current valid versions are 0 and 1, and the effect of setting each of those
> valid version numbers. Note that some other parameters have maybe half a
> page of accompanying explanatory comment. It's better to write a bit too
> much rather than too little, and ensures our interface is well documented
> and hence well used and maintained, because others will understand it.
> Apart from this one point, I am happy for the entire patch series to be
> checked in. So once you've made that improvement:
> Acked-by: Keir Fraser <keir@xxxxxxx>

Thanks, I will do that!

Anthony PERARD

Xen-devel mailing list