Re: [Xen-devel] Re: [Patch] support of cpu pools in xl

To:	Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] Re: [Patch] support of cpu pools in xl
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Mon, 20 Sep 2010 06:58:54 +0200
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date:	Sun, 19 Sep 2010 21:59:47 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1284958736; x=1316494736; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4C96EA0E.7090105@xxxxxxxxxxxxxx>\|Date:=20 Mon,=2020=20Sep=202010=2006:58:54=20+0200\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20Ian=20Campbell=20<Ian.Campbell@xxxxxxxxxxxxx >\|CC:=20Ian=20Jackson=20<Ian.Jackson@xxxxxxxxxxxxx>,=20 =0D=0A=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@lis ts.xensource.com>\|Subject:=20Re:=20[Xen-devel]=20Re:=20[P atch]=20support=20of=20cpu=20pools=20in=20xl\|References: =20<4C930642.3080802@xxxxxxxxxxxxxx>=09<1284716808.16095. 3185.camel@xxxxxxxxxxxxxxxxxxxxxx>=09<4C9353EC.1060402@ts .fujitsu.com>=09<1284724524.16095.3412.camel@xxxxxxxxxxxx source.com>=09<19603.36623.571453.446278@xxxxxxxxxxxxxxxx urce.com>=20<1284748120.15518.246.camel@xxxxxxxxxxxxxxxxx main>\|In-Reply-To:=20<1284748120.15518.246.camel@localhos t.localdomain>\|Content-Transfer-Encoding:=207bit; bh=7ZoaMkSmHcrCNTPieFhEggBtslXH7d4jSMxsgV3F25A=; b=vaE8rtThVYIQrVItu/lEngjZO/Ej9MZs5fru5TSJirWTqNY8+fwMx8dm MQ8EsY1ERyK2hwQaXC/DCbxdIhALXmWEu6yadWUs4Pnn5RwiO3j4SGqGp +3l7o0smJDY6vSEYCLF6KDp1ShbRb9mcht7MdwxkvEbaE0xoHo9XpioH2 vcZ+YDz2m79+3n/OQU7/ldMenE0D1zaPluvjNlH7mofvt8rBNyZOLb+8Y IR/p5wzARfa2/teMLXlc8FqqrgZr+;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=V6qR5gX5Z0eZSxUJ9nHb5AktW5UqIQTuu4PA/5mpMzeh/8eub0rQIBoN M6jK7pjJG/UTR40ccWuTjqIZ01XdJ5bqCp/kHV6dEVbNBx/Q6gkAsXvdv bBHUzf65nYTzRuGm0pAMWhnqJPhf4QLfsvfOzc2wNV0yoTcGmSTWXsNyN q98oOiwXpIANDhXQvqP3878StWHnYfS4i8gK+2+ki1fC+3kw5GcWg51TN us/3JwmmlQ/cmhkIjR44MOflna8jg;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1284748120.15518.246.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<4C930642.3080802@xxxxxxxxxxxxxx> <1284716808.16095.3185.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C9353EC.1060402@xxxxxxxxxxxxxx> <1284724524.16095.3412.camel@xxxxxxxxxxxxxxxxxxxxxx> <19603.36623.571453.446278@xxxxxxxxxxxxxxxxxxxxxxxx> <1284748120.15518.246.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Iceowl/1.0b1 Icedove/3.0.6

On 09/17/10 20:28, Ian Campbell wrote:

On Fri, 2010-09-17 at 16:53 +0100, Ian Jackson wrote:

Ian Campbell writes ("Re: [Xen-devel] Re: [Patch] support of cpu pools in xl"):

On Fri, 2010-09-17 at 12:41 +0100, Juergen Gross wrote:

I just wanted to be able to support some (inactive) cpupools without any
cpu allocated. It's just a number which should normally be large enough.


What is the purpose of these inactive cpupools?


Amongst other things, I would guess, the creation or removal of
cpupools !


"Inactive cpupools" were meant to be cpupools without any cpus and domains
assigned to them.
They can exist for a short time during creation and removal, but due to
explicitly removing all cpus, too.

I don't think so, libxl_create_cpupool returns a new poolid for a newly
created pool, so they are not needed for that.


They have a poolid, but there might be more cpupools than cpus in the system.
This was the reason for the "+ 32". But I agree, this should be done via a
#define.

BTW I noticed that we have libxl_list_pool vs
libxl_{create,destroy}_cpupool and
libxl_cpupool_{cpuadd,cpuremove,movedomain}. I think the interface
should use cpupool throughout and not just pool to make it clear what it
is a pool of. IOW libxl_list_pool should be libxl_list_cpupool, the type
should be called  libxl_cpupool and functions such as
libxl_name_to_poolid should instead be libxl_name_to_cpupoolid.


Okay, I'll change it.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] Re: [Patch] support of cpu pools in xl