On Mon, 2010-09-13 at 10:57 +0200, Matthias Klose wrote:
> On 13.09.2010 10:38, Ian Campbell wrote:
> > On Sun, 2010-09-12 at 16:25 +0200, Matthias Klose wrote:
> >> there are at least some syntax errors when trying to use the xen utils with
> >> python2.6. The attached patch changes these string exception into
> >> ValueError's.
> >
> > Thanks Matthias.
> >
> >> - tools/python/xen/util/bugtool.py (getBugTitle)
> >> - tools/python/xen/xend (class XendBase): not catched
> >> - tools/python/xen/xm/xenapi_create.py (sxp2xmlconvert_sxp_to_xml):
> >> the method already raises a ValueError for similiar condition.
> >> - tools/python/xen/xm/main.py (xm_network_attach): not catched.
> >>
> >> For all but maybe the first one, the replacement of the string exceptions
> >> into
> >> ValueError's seems to be safe.
> >
> > Why is the first one potentially unsafe?
>
> because I didn't check where it's used.
>
> > What do you mean by "not catched" here? Just that nothing catches the
> > exception?
>
> yes, and the first one seems to match this definition too.
I suspect so too, I think these changes are good.
>
> > Please could you provide a Signed-off-by line for upstream?
>
> hmm, any pointers? I hope my friendly distribution packager could help ...
As with the Linux kernel Xen requires that contributions are signed off
to indicate that the code is suitable (copyright-wise etc) for inclusion
in Xen. e.g.
Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxxxxx>
except with your name and email address.
You can find the precise meaning in the Linux
upstream kernel tree (Documentation/SubmittingPatches, copy below).
Ian.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home