| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [Pkg-xen-devel] using xen tools with python2.6
On 13.09.2010 11:14, Ian Campbell wrote:
On Mon, 2010-09-13 at 10:57 +0200, Matthias Klose wrote:
On 13.09.2010 10:38, Ian Campbell wrote:
On Sun, 2010-09-12 at 16:25 +0200, Matthias Klose wrote:
there are at least some syntax errors when trying to use the xen utils with
python2.6. The attached patch changes these string exception into ValueError's.
Thanks Matthias.
- tools/python/xen/util/bugtool.py (getBugTitle)
- tools/python/xen/xend (class XendBase): not catched
- tools/python/xen/xm/xenapi_create.py (sxp2xmlconvert_sxp_to_xml):
the method already raises a ValueError for similiar condition.
- tools/python/xen/xm/main.py (xm_network_attach): not catched.
For all but maybe the first one, the replacement of the string exceptions into
ValueError's seems to be safe.
Why is the first one potentially unsafe?
because I didn't check where it's used.
What do you mean by "not catched" here? Just that nothing catches the
exception?
yes, and the first one seems to match this definition too.
I suspect so too, I think these changes are good.
Please could you provide a Signed-off-by line for upstream?
hmm, any pointers? I hope my friendly distribution packager could help ...
As with the Linux kernel Xen requires that contributions are signed off
to indicate that the code is suitable (copyright-wise etc) for inclusion
in Xen. e.g.
Signed-off-by: Ian Campbell<ian.campbell@xxxxxxxxxxxxx>
except with your name and email address.
You can find the precise meaning in the Linux
upstream kernel tree (Documentation/SubmittingPatches, copy below).
thanks, attached the patch with this line added.
Matthias
tools-python2.6.diff
Description: Text document
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home