Hi, Tim, sorry for the long delay for the updated patch. Can you please have a
review for it? I will update according to your feedback, and re-send as a
seperated patch submission.
I'm not sure if the change to the _gfn_to_mfn_type() is acceptable. Especially,
if it is right to change the mfn to be INVALID_MFN. The idea to change the mfn
to be INVALID_MFN is, we don't need to change every caller for broken type (I
noticed the PoD/sharing etc checked each caller), but depends on caller will
check the mfn to be valid or not. But that may have some potential issue: Some
caller may assume the mfn should not be INVALID_MFN (since hypervisor setup the
p2m table) and BUG() on INVALID_MFN. I try to check the code and didn't find
such situation. Do you think if it is reasonable?
I'm now working on support for PoD/Shared memory.
Thanks
--jyh
>-----Original Message-----
>From: Tim Deegan [mailto:Tim.Deegan@xxxxxxxxxx]
>Sent: Friday, July 16, 2010 4:52 PM
>To: Jiang, Yunhong
>Cc: Keir Fraser; xen-devel
>Subject: Re: [PATCH] Unmmap guest's EPT mapping for poison memory
>
>At 07:45 +0100 on 16 Jul (1279266321), Jiang, Yunhong wrote:
>> I'm not sure. At least it should work for EPT on 32-bit, since EPT
>> table can support >8 p2m type per my understanding.
>
>Yes, that's OK, at least while this is EPT-only.
>
>Cheers,
>
>Tim.
>
>--
>Tim Deegan <Tim.Deegan@xxxxxxxxxx>
>Principal Software Engineer, XenServer Engineering
>Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)
p2mt.patch
Description: p2mt.patch
mca_handler.patch
Description: mca_handler.patch
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home