Re: [Xen-devel] RE: xl fails to work with some command

[Weidong Han <weidong.han@xxxxxxxxx>]

Ian Campbell wrote:
> On Tue, 2010-08-31 at 10:40 +0100, Stefano Stabellini wrote:
>   
> > On Tue, 31 Aug 2010, Weidong Han wrote:
> >     
> > > > As stated above, xl doesn't know how to FLR a device, the dom0 kernel
> > > > provides a way to do it.
> > > > XCP kernels have pciback do_flr that has all the HW specific FLR
> > > > functions you are referring to AFAIK, but the pvops kernel, that uses
> > > > the standard reset node, does not.
> > > >
> > > >   
> > > >         
> > > So it should implement specific FLRs in pciback like XCP/XCI.
> > >
> > >       
> >  
> > Why should we reimplement pci FLR in pciback when the kernel has
> > already a way to do it?
> > I am not seeing pciback FLR going upstream easily.
> > Besides if some devices need specific FLRs, shouldn't the generic kernel
> > FLR function know about it?
> >     
> Yes, absolutely, the correct way to fix this is to add the necessary
> fixes/quirks to the upstream FLR infrastructure so that everybody
> benefits, not to add stuff to pciback where a) only Xen benefits and b)
> we have to maintain it forever because it cannot be upstreamed because
> the correct fix is to fix it in the upstream LFR infrastructure ;-).
>
> Ian.
>
>
> I totally agree with you. It's the best to push the specific FLRs to Linux FLR 
> infrastructure. I'm afraid it will need many efforts. But it's the right 
> direction anyway.
Regards,
Weidong
>  
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel