This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] add SONAME to libblktapctl.so

Ian Jackson writes ("Re: [Xen-devel] [PATCH] add SONAME to libblktapctl.so"):
> That's a convincing explanation.  In which case, as regards your
> patch,
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> and we should have a separate changeset to remove -fPIC and -rdynamic.

And here that one is:

tools/blktap2: Remove unnecessary -fPIC and -rdynamic from link line

Where these options are needed they will be in the appropriate *FLAGS
variables; they should not appear in specific Makefiles.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r ddb9f47ef2e2 tools/blktap2/control/Makefile
--- a/tools/blktap2/control/Makefile    Thu Aug 12 18:56:20 2010 +0100
+++ b/tools/blktap2/control/Makefile    Fri Aug 13 13:34:49 2010 +0100
@@ -61,7 +61,7 @@ tap-ctl: tap-ctl.o $(LIBNAME).so
        $(AR) r $@ $^
$(SHLIB_LDFLAGS) -rdynamic $^ -o $@
$(SHLIB_LDFLAGS) $^ -o $@
 install: $(IBIN) $(LIB_STATIC) $(LIB_SHARED)

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>