This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] add SONAME to libblktapctl.so

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] add SONAME to libblktapctl.so
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Thu, 12 Aug 2010 11:42:38 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 12 Aug 2010 02:43:40 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1281606165; l=1052; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=2LUuB8wH4QFe0Vx23Ps77bh/7zc=; b=NTCV+IgyQEyeFby33eR0C06FAdpgoUoFMdgcKSCfXMzfyZ8bEioYl5A/lh8inDAEsE5 9FwolTPEkMiZ9frMMh6ChGUVOEvnomxSqCzDKEQ/tHEOXhqaUj70jbnJ9LnuaVXSgbL20 upO29wP+iTEoaiuIQThK57K6Bsb4lh0L5JQ=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19554.42879.224718.693010@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100728152348.GA6308@xxxxxxxxx> <C8760BCA.1BEA6%keir.fraser@xxxxxxxxxxxxx> <20100801094935.GA5265@xxxxxxxxx> <19554.42879.224718.693010@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Aug 11, Ian Jackson wrote:

> > -libblktapctl.so: $(CTL_PICS)
> > -   $(CC) $(CFLAGS) -fPIC -shared -rdynamic $^ -o $@
> > $(SHLIB_LDFLAGS) -rdynamic $^ -o $@
> I'm not sure I understand why -fPIC appears here as a literal, rather
> than being included via some more general make variable.  And does it
> have any effect on the shared library creation link line anyway ?
> Other places that make shared libraries don't have -fPIC there.
> Likewise they don't say -rdynamic.


maybe someone has over-done things here. I'm sure libblktapctl is most
likely not different from all the other xen libraries. So I would just
drop -fPIC and -rdynamic from the options.

The gcc manual states that linking should be done with the same options
used to compile the individual objects, to get predictable results. So
if for example -fPIC wasnt there before (in CFLAGS), it wont make the
resulting lib any better.


Xen-devel mailing list