WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] add SONAME to libblktapctl.so

Olaf Hering writes ("Re: [Xen-devel] [PATCH] add SONAME to libblktapctl.so"):
> maybe someone has over-done things here. I'm sure libblktapctl is most
> likely not different from all the other xen libraries. So I would just
> drop -fPIC and -rdynamic from the options.
> 
> The gcc manual states that linking should be done with the same options
> used to compile the individual objects, to get predictable results. So
> if for example -fPIC wasnt there before (in CFLAGS), it wont make the
> resulting lib any better.

That's a convincing explanation.  In which case, as regards your
patch,

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

and we should have a separate changeset to remove -fPIC and -rdynamic.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel