This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [xen-devel][vNUMA v2][PATCH 2/8] public interface

To: Dulloor <dulloor@xxxxxxxxx>
Subject: Re: [xen-devel][vNUMA v2][PATCH 2/8] public interface
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 3 Aug 2010 20:52:26 +0100
Cc: Andre Przywara <andre.przywara@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 03 Aug 2010 12:53:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTin4Rx-mhu8kRUmRh5PDubQvsZWtbm7kw_ZmqLuj@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcszMMxtrdjJbr2VTveJlNYkFEKLVAAFJkk3
Thread-topic: [xen-devel][vNUMA v2][PATCH 2/8] public interface
User-agent: Microsoft-Entourage/
On 03/08/2010 18:24, "Dulloor" <dulloor@xxxxxxxxx> wrote:

> But, what I could do is to leave out vnode_to_mnode translation for
> now and add it along with ballooning support
> (if/when we decide to add it). I will just bump up the interface
> version at that time. That might give us time to mull this over ?

I would rename your 'nr_vnodes' field to 'nr_nodes' and your 'mnode_id'
field to 'node_id'. Then I'm happy. It's the unnecessary distinction between
vnodes and mnodes that I was troubled by -- the two can be collapsed
together and the interface is clearer that way.

 -- Keir

Xen-devel mailing list