This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: softirq warnings when calling dev_kfree_skb_irq - bug in

To: David Miller <davem@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: softirq warnings when calling dev_kfree_skb_irq - bug in conntrack?
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 03 Aug 2010 12:16:39 -0700
Cc: Xen-devel@xxxxxxxxxxxxxxxxxxx, Ian.Campbell@xxxxxxxxxx, eric.dumazet@xxxxxxxxx, netdev@xxxxxxxxxxxxxxx, dongxiao.xu@xxxxxxxxx, johannes@xxxxxxxxxxxxxxxx, kaber@xxxxxxxxx
Delivery-date: Tue, 03 Aug 2010 12:17:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100803.002318.209965574.davem@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C571476.7070301@xxxxxxxx> <1280819074.3874.8.camel@xxxxxxxxxxxxxxxxxxxxx> <20100803.002318.209965574.davem@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1
 On 08/03/2010 12:23 AM, David Miller wrote:
From: Johannes Berg<johannes@xxxxxxxxxxxxxxxx>
Date: Tue, 03 Aug 2010 09:04:34 +0200

I had this too:

But I'm not convinced it's conntrack, I'd think it's

commit 15e83ed78864d0625e87a85f09b297c0919a4797
Author: Eric Dumazet<eric.dumazet@xxxxxxxxx>
Date:   Wed May 19 23:16:03 2010 +0000

     net: remove zap_completion_queue

which, from the looks of it, ought to be reverted because it failed to
take into account that dev_kfree_skb() can do more things that require
non-irq-context than just calling skb->destructor, like for instance the
conntrack thing we see here.
Agreed.  I'll revert this and queue that up for 2.6.35-stable

Reverting this change fixes the problem for me.


Xen-devel mailing list