| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: softirq warnings when calling dev_kfree_skb_irq - bug in
|
To: |
johannes@xxxxxxxxxxxxxxxx |
|
Subject: |
[Xen-devel] Re: softirq warnings when calling dev_kfree_skb_irq - bug in conntrack? |
|
From: |
David Miller <davem@xxxxxxxxxxxxx> |
|
Date: |
Tue, 03 Aug 2010 00:23:18 -0700 (PDT) |
|
Cc: |
jeremy@xxxxxxxx, Xen-devel@xxxxxxxxxxxxxxxxxxx, Ian.Campbell@xxxxxxxxxx, eric.dumazet@xxxxxxxxx, netdev@xxxxxxxxxxxxxxx, dongxiao.xu@xxxxxxxxx, kaber@xxxxxxxxx |
|
Delivery-date: |
Tue, 03 Aug 2010 00:23:51 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1280819074.3874.8.camel@xxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<4C571476.7070301@xxxxxxxx> <1280819074.3874.8.camel@xxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Date: Tue, 03 Aug 2010 09:04:34 +0200
> I had this too:
> http://article.gmane.org/gmane.linux.network/167590
>
> But I'm not convinced it's conntrack, I'd think it's
>
> commit 15e83ed78864d0625e87a85f09b297c0919a4797
> Author: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> Date: Wed May 19 23:16:03 2010 +0000
>
> net: remove zap_completion_queue
>
> which, from the looks of it, ought to be reverted because it failed to
> take into account that dev_kfree_skb() can do more things that require
> non-irq-context than just calling skb->destructor, like for instance the
> conntrack thing we see here.
Agreed. I'll revert this and queue that up for 2.6.35-stable
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home