xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH]libxc: fix a Segmentation fault

from [Yang Hongyang]

[Permanent Link][Original]

To:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH]libxc: fix a Segmentation fault
From:	Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
Date:	Tue, 29 Jun 2010 08:40:21 +0800
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Mon, 28 Jun 2010 17:40:30 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<19496.50624.967390.571291@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<4C284523.4000304@xxxxxxxxxxxxxx> <19496.50624.967390.571291@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100423 Thunderbird/3.0.4

On 06/28/2010 11:54 PM, Ian Jackson wrote:
> Yang Hongyang writes ("[Xen-devel] [PATCH]libxc: fix a Segmentation fault"):
>> # xl list
>> xc: error: Could not obtain handle on privileged command interface (2 = No 
>> such file or directory): Internal error
>> Segmentation fault
>>
>> This is because xc free the logger which xl created.
> 
> Well spotted.  You're right about the cause, but your fix is not
> correct.  The correct fix is that xc_interface_open's error path
> should free error_handler_tofree rather than error_handler.  So there
> is no need to add another variable.  I will apply that fix.
> 

OK,Thanks Ian.

> Thanks,
> Ian.
> 
> 


-- 
Regards
Yang Hongyang

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH]libxc: fix a Segmentation fault, Yang Hongyang Re: [Xen-devel] [PATCH]libxc: fix a Segmentation fault, Ian Jackson Re: [Xen-devel] [PATCH]libxc: fix a Segmentation fault, Yang Hongyang <=

Previous by Date:	Re: [Xen-devel] [Fwd: [Xen-users] Dom0 and memory], Luís Silva
Next by Date:	Re: [Xen-devel] [PATCH] add a command to get the state of VMs, James Song
Previous by Thread:	Re: [Xen-devel] [PATCH]libxc: fix a Segmentation fault, Ian Jackson
Next by Thread:	[Xen-devel] One question to p2m type, Jiang, Yunhong
Indexes:	[Date] [Thread] [Top] [All Lists]